You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
node-integration-tests: port trace semantics suites to span streaming #24140
Sampling, DSC, envelope headers and span linking. These suites assert on envelope headers and trace propagation rather than on instrumentation output, so they are the ones most likely to expose a real product bug rather than a test rewrite.
Public API span surface: public-api/startSpan/* (7 dirs), public-api/beforeSendSpan-static, public-api/bindScopeToEmitter, public-api/setMeasurement, public-api/scopes/*
Twins to fold back
tracing/sampling-streamed, tracing/ignoreSpans-streamed/*, public-api/beforeSendSpan-streamed, context-streamed/*, and the 6 public-api/startSpan/*-streamed dirs.
Keep static trace lifecycle coverage
This is the group that owns the guard. Keep tracing/sampling-static and public-api/beforeSendSpan-static on the static pin. Everything else moves.
Is anyone working on the seven tracing/envelope-header/* suites? I'd like to take that group as a separate PR.
I tried the migration locally on 7267c254. All seven pass with span-header assertions and the existing error-header checks. The sampling-propagation fixture also needs sentry-public_key in its incoming baggage, since streamed envelopes omit tracing context without it. No SDK runtime changes appear necessary.
Activity
linear-code commentedon Sep 7, 2026
JS-3610
ihsraham commentedon Sep 16, 2026
Is anyone working on the seven
tracing/envelope-header/*suites? I'd like to take that group as a separate PR.I tried the migration locally on
7267c254. All seven pass with span-header assertions and the existing error-header checks. The sampling-propagation fixture also needssentry-public_keyin its incoming baggage, since streamed envelopes omit tracing context without it. No SDK runtime changes appear necessary.Would that scope work for you?
msonnb commentedon Sep 16, 2026
@ihsraham sounds good, feel free to open a PR!
test(node): Run sampling propagation tests with default streaming (#2…
test(node): Use default streaming in scope and span suites (#25222)
test(node): Port baggage and metadata tests to span streaming (#25220)
test(node): Port span linking and raw OTel tests to streaming (#25219)
test(node): Port parallel span and naming tests to streaming (#25217)
test(node): Port trace context tests to span streaming (#25218)
test(node): Port basic and nested startSpan tests to streaming (#25214)