Skip to content

Handle GitHub token revocation failures#102

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/high-impact-sentry-errors-4f5f
Draft

Handle GitHub token revocation failures#102
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/high-impact-sentry-errors-4f5f

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor Bot commented May 2, 2026

Summary

  • Make GitHub App installation token revocation best-effort so cleanup transport/API failures do not convert successful webhook processing into 500s.
  • Log revocation failures with exception context; tokens still expire automatically.
  • Add a regression test for a requests.ConnectionError during token cleanup.

Verification

  • . .venv/bin/activate && pytest tests/test_github_app.py tests/test_web_app_handler.py tests/test_github_sdk.py -> 16 passed, 1 skipped
  • . .venv/bin/activate && pytest -> 20 passed, 1 skipped

Fixes SENTRY-GITHUB-ACTIONS-APP-6M

Open in Web View Automation 

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant