feat: SentryOptions.EnableMetrics is obsolete and ignored

[jamescrosswell]

Guidance

Guidance	.NET metrics today	Action
Don't remove enableMetrics in a minor; remove in the next major	—	Kept, marked [Obsolete], removal scheduled for 7.0.0
Don't gate the manual APIs behind the option	❌ SentrySdk.Metrics is gated	Fixed here
No real double opt-in	Already true by default, not a separate integration	Nothing to do
Don't change the default if it forces other opt-in config	Default was already true	Nothing to do
Auto-added integrations must not send metrics	No such integrations	N/A

So the only mandated change is ungating the manual API — and in .NET that happens to be the whole option. EnableMetrics had exactly one functional consumer, SentryMetricEmitter.Create, which backs SentrySdk.Metrics. Nothing else reads it: there is no automatic metric collection to keep gating. Ungating the manual API and ignoring the option are therefore the same edit.

Not a removal

The option stays on SentryOptions, still binds from configuration (an existing "EnableMetrics" key resolves and is ignored rather than throwing), and keeps its place in BindableSentryOptions. The getter returns true, the setter is a no-op, and the obsolete message names 7.0.0 as the removal version. To drop metrics, use SetBeforeSendMetric and return null.

Notes for review

TraceConnectedMetricsAnalyzerTests had an Init method in its analyzer source snippet whose only purpose was setting EnableMetrics = false. With the option obsolete that snippet emits CS0618, which the Roslyn test harness reports as an unexpected diagnostic, so the method was dropped — it contributed nothing to what the analyzer test covers.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.73%. Comparing base (4e0e0de) to head (6380616).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5509      +/-   ##
==========================================
- Coverage   74.74%   74.73%   -0.02%     
==========================================
  Files         513      513              
  Lines       18829    18828       -1     
  Branches     3682     3681       -1     
==========================================
- Hits        14074    14071       -3     
- Misses       3875     3877       +2     
  Partials      880      880              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.