Skip to content

feat(platform-redirect): alert for unavailable platforms for automated instrumentation #16833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aldy505 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

feat(platform-redirect): alert for unavailable platforms for automated instrumentation #16833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/platform-redirect/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ export default async function Page(props: {
}

const pathname = sanitizeNext(next);
const isTracingAutomatedInstrumentation =
pathname === '/tracing/instrumentation/automatic-instrumentation';
const rootNode = await getDocsRootNode();
const defaultTitle = 'Platform Specific Content';
let description = '';
Expand Down Expand Up @@ -149,6 +151,12 @@ export default async function Page(props: {
return (
<DocPage frontMatter={frontMatter}>
<Alert>{platformInfo}</Alert>
{isTracingAutomatedInstrumentation && (
<Alert>
This page lists only platforms with automated tracing instrumentation. Some
platforms may be omitted due to technical limitations.
</Alert>
)}
Comment on lines 153 to +159
Copy link
Contributor

@sfanahata sfanahata Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Alert>{platformInfo}</Alert>
{isTracingAutomatedInstrumentation && (
<Alert>
This page lists only platforms with automated tracing instrumentation. Some
platforms may be omitted due to technical limitations.
</Alert>
)}
<Alert>
{platformInfo}
{isTracingAutomatedInstrumentation && (
<>
<br />
<br />
This page lists only platforms with automated tracing instrumentation. Some
platforms may be omitted due to technical limitations.
</>
)}
</Alert>

Maybe make this one alert so there's not alert fatigue? Or, if you want to keep them separate, let's change the color of the second:

{isTracingAutomatedInstrumentation && (
  <Alert level="warning">
    This page lists only platforms with automated tracing instrumentation. Some
    platforms may be omitted due to technical limitations.
  </Alert>
)}```

Copy link
Collaborator Author

@aldy505 aldy505 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep let's change the color.


<ul>
{platformOrGuideList.map(p => (
Expand Down
Loading