-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Symfony sentry handler #15932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Symfony sentry handler #15932
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| ```yaml {filename:config/packages/monolog.yaml} | ||
| monolog: | ||
| handlers: | ||
| sentry_logs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The updated Monolog handler configuration guide omits the fillExtraContext argument, which defaults to false, silently stopping Monolog context and extra data from being sent to Sentry.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The documentation change migrates from a deprecated type: sentry Monolog handler to the Sentry\Monolog\Handler service. The previous configuration effectively set fill_extra_context: true. The new configuration example omits the corresponding fillExtraContext argument in the handler's constructor. Since the default value for fillExtraContext is false, users following the new guide will silently lose Monolog context and extra data in their Sentry events. This is a functional regression that can hinder debugging efforts by reducing the amount of diagnostic information available.
💡 Suggested Fix
To maintain feature parity, explicitly set the fillExtraContext argument to true in the new YAML configuration example.
Sentry\Monolog\Handler:
arguments:
- '@Sentry\State\HubInterface'
- !php/const Monolog\Logger::ERROR
- true # bubble
- true # fillExtraContextAlternatively, document this as a breaking change.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/platforms/php/guides/symfony/integrations/monolog.mdx#L52-L56
Potential issue: The documentation change migrates from a deprecated `type: sentry`
Monolog handler to the `Sentry\Monolog\Handler` service. The previous configuration
effectively set `fill_extra_context: true`. The new configuration example omits the
corresponding `fillExtraContext` argument in the handler's constructor. Since the
default value for `fillExtraContext` is `false`, users following the new guide will
silently lose Monolog context and extra data in their Sentry events. This is a
functional regression that can hinder debugging efforts by reducing the amount of
diagnostic information available.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8342759
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES