Open
Conversation
Demonstrates that the SDK incorrectly uses the baggage sample_rate when the sentry-trace header is missing, instead of using the locally configured traces_sample_rate. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a reproduction for getsentry/sentry-php#1999
The reproduction demonstrates that the SDK incorrectly uses the
sentry-sample_ratevalue from the baggage header to make a sampling decision when thesentry-traceheader is missing.How to Run
cd sentry-php/1999 composer install php reproduce.phpOutput
Expected Behavior
Without a
sentry-traceheader, the SDK should treat this as a new trace head and use the locally configuredtraces_sample_rate(0.0) instead of the baggage sample rate (1.0).