fix(telemetry): Capture tool result outputs#792
Closed
obostjancic wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
reviewed
Jul 8, 2026
Keep the active Sentry span reachable across async tool execution so tool result attributes are written alongside tool inputs. Include model-facing content for content-only tool results while avoiding duplicate JSON echoes for structured results. Co-Authored-By: ChatGPT <chatgpt@openai.com>
obostjancic
force-pushed
the
fix/tool-result-telemetry-output
branch
from
04a9f72 to
86b3a97
Compare
dcramer
reviewed
Jul 8, 2026
| normalized: ReturnType<typeof normalizeToolResult>, | ||
| ) => { | ||
| const { content, details } = normalized; | ||
| if (isRecord(details) && details.rawResult !== undefined) { |
Member
There was a problem hiding this comment.
i need to f/u here im not sure why we have this rawResult thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool execution spans now retain their Sentry span handle across async tool execution, so result attributes are written on the same span that already has tool inputs. Content-only tool results include their model-facing content in public telemetry, while structured results avoid duplicating the JSON details as a generated text content part.
Regression coverage exercises both content-only outputs and structured results so reviewers can verify the payload shape without reconstructing the trace path.