fix(oauth): Retain refresh token when providers omit rotation#775
Open
Elih96 wants to merge 1 commit into
Open
fix(oauth): Retain refresh token when providers omit rotation#775Elih96 wants to merge 1 commit into
Elih96 wants to merge 1 commit into
Conversation
Co-Authored-By: Codex <codex@openai.com>
|
@Elih96 is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin OAuth refreshes now keep the stored refresh token when a provider returns a new access token without a
refresh_token. This covers providers like Asana that do not rotate refresh tokens on refresh; previously those responses were rejected, so plugin auth failed consistently after the access token expired.Fresh authorization responses still require a refresh token, and explicitly invalid refresh token values are still rejected instead of silently falling back to the stored credential. Verified with
pnpm --filter @sentry/junior exec vitest run tests/unit/plugins/oauth-token-response.test.ts.