fix(package): rewrite published type import paths - #1677
Open
sentry-junior[bot] wants to merge 4 commits into
Open
fix(package): rewrite published type import paths#1677sentry-junior[bot] wants to merge 4 commits into
sentry-junior[bot] wants to merge 4 commits into
Conversation
Emit consumer-resolvable .d.ts by rewriting monorepo @/ imports after tsc, and prove closed experimental keys with a packed consumer typecheck. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Keep the rewrite and consumer typecheck, drop extra APIs and scripts. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
dcramer
marked this pull request as ready for review
August 24, 2026 23:16
Trim two pre-existing dashboard files so workspace lint can pass. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
force-pushed
the
fix/package-declaration-paths
branch
from
August 24, 2026 23:21
d060fa6 to
91366b3
Compare
Dashboard visual evidenceMode: path-selected Triggered by:
Component gallery index · desktop
Full-page screenshots from the mock dashboard. Not a pixel-diff gate. |
Replace the hand-written declaration rewrite with tsc-alias, the common post-tsc tool for this job. Keep the packed consumer typecheck. Co-Authored-By: David Cramer <david@sentry.io>
Member
|
maybe instead we should just correctly publish exports/types for anything that is expected to be imported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Published package types kept internal
@/imports. Outside this repo, TypeScript could not load those types, so unknown experimental feature names were not rejected.After type emit, run
tsc-aliasso@/imports become normal relative paths. That is the common tool for this job.After package build, pack the package and typecheck a tiny app: a known experimental feature passes, an unknown one fails.
This is separate from the runtime warn path for unknown experimental features.
Requested by David Cramer.
--
View Junior Session [Sentry]