Skip to content

fix(updater): skip update when pinned hash not ancestor of latest tag - #173

Open
jpnurmi wants to merge 4 commits into
mainfrom
jpnurmi/fix/updater-pin
Open

jpnurmi wants to merge 4 commits into
mainfrom
jpnurmi/fix/updater-pin

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Skip CMake and submodule updates when the latest matching tag does not contain the pinned commit, preserving the current revision without failing the workflow. Updates to releases that contain the pinned commit continue normally.

Fixes:

…st tag

Handle dependencies pinned to a commit hash that is not in the history
of the latest matching tag by skipping the update instead of rolling
forward. Escape latestTag in ls-remote tag matching, bypass semver
comparison for hashes, and reset LASTEXITCODE on negative ancestry
checks to avoid false script failures.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c4a1e82. Configure here.

Comment thread updater/scripts/update-dependency.ps1
@jpnurmi jpnurmi changed the title fix(updater): skip CMake update when pinned hash not ancestor of latest tag fix(updater): skip update when pinned hash not ancestor of latest tag Sep 15, 2026
@jpnurmi
jpnurmi requested a review from vaind September 15, 2026 15:29
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️ Could not load custom Dangerfile: .github/test-dangerfile-curl.js Error: ENOENT: no such file or directory, lstat '/github/workspace/.github/test-dangerfile-curl.js'

Generated by 🚫 dangerJS against f8c380e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant