Skip to content

fix(web): blur site header behind search palette - #217

Merged
maxktz merged 2 commits into
mainfrom
fix/header
Sep 27, 2026
Merged

maxktz merged 2 commits into
mainfrom
fix/header

Conversation

@maxktz

@maxktz maxktz commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Keep the fixed site headers below the Fumadocs search palette overlay.
  • Keep the mobile navigation overlay directly below its header.

Validation

  • pnpm --filter web typecheck
  • pnpm --filter web lint
  • pnpm exec oxfmt --check apps/web/src/components/layout/navigation-bar.tsx apps/web/src/components/layout/mini-nav-bar.tsx apps/web/src/styles/globals.css
  • git diff --check

Summary by cubic

Fixes stacking so the Fumadocs search palette overlay renders above the fixed site headers instead of underneath them.

  • Lowers the fixed header layers from z-99 to z-49 and the mobile nav overlay from z-98 to z-48.
  • Removes the now-unneeded z-index override that lifted the context menu above the headers.

Written for commit d6c27c8. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the stacking order of the navigation bars, mobile menu, and brand context menu. These interface elements now appear at lower levels in the page’s visual layer order.

@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
paykit Ready Ready Preview Sep 27, 2026 1:08pm UTC

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 007a5402-76f5-4a41-aa0f-ae37d185dd44

📥 Commits

Reviewing files that changed from the base of the PR and between 400fcdc and d6c27c8.

📒 Files selected for processing (4)
  • apps/web/src/components/layout/mini-nav-bar.tsx
  • apps/web/src/components/layout/navigation-bar.tsx
  • apps/web/src/components/web/brand-menu.tsx
  • apps/web/src/styles/globals.css
💤 Files with no reviewable changes (2)
  • apps/web/src/styles/globals.css
  • apps/web/src/components/web/brand-menu.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Fixed navigation and mobile overlay stacking indices were lowered. The BrandMenu positioner class and a global CSS rule that raised context-menu positioners above navigation were removed.

Changes

Navigation and context-menu stacking

Layer / File(s) Summary
Update navigation and context-menu stacking
apps/web/src/components/layout/mini-nav-bar.tsx, apps/web/src/components/layout/navigation-bar.tsx, apps/web/src/components/web/brand-menu.tsx, apps/web/src/styles/globals.css
The fixed navigation container and header use lower stacking indices, as does the mobile overlay. BrandMenu no longer sets a positioner class, and the global context-menu z-index rule was removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d6c27

Users should see the search palette above the fixed headers and the mobile navigation overlay below its header. The context menu retains its component layer, and no concrete stacking regression remains; the changes appear ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: lowering site header stacking layers so the search palette can blur the header behind it.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops past the header in the night
The menu rests at a lower height
No extra class lifts it to the sky
The old rule waves its last goodbye
Soft paws check the stack, then bound from sight

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread apps/web/src/styles/globals.css Outdated
@maxktz
maxktz merged commit 4a9ac43 into main Sep 27, 2026
11 checks passed

This branch was successfully deployed

1 active deployment
Preview — d6c27c8c Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant