chore(release): set main to 1.9.6 - #393
Conversation
v1.9.6 is tagged and building; main was still declaring 1.9.5. Same move as `a0eca303 chore(release): set main to 1.9.5` after the previous release, and written by the same script promote.yml uses (.github/scripts/set-release-version.mjs), so package-lock.json is updated alongside package.json rather than left behind. This exists as its own commit because the sync PR that promote.yml opened (#392) cannot do the job. That branch was cut from the v1.9.5 TAG, whose content main already carries under different SHAs from the earlier rebase-merge, so the PR carries 39 commits of which 23 are duplicates -- which is why the rebase-merge failed five times. Worse, its net diff against main is a reversion: 1889 deletions taking out the whole updater stack (auto-updater, install-channel, update-checker, mac-update-feed), the editor's OpenProjectModal test, and 111 lines of build.yml -- everything that landed on main after v1.9.5 and was deliberately kept out of the 1.9.6 patch release. The conflict was load-bearing. Closing #392 rather than merging it; this is the only part of it main wants.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe package version in ChangesPackage release
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The PR only updates release metadata and the associated Nix dependency hash, with no source-behavior change. The hash is consistent with the lockfile and Nix validation, so no actionable merge-blocking risk remains beyond normal CI checks. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bumping the version rewrites package-lock.json, which is exactly what invalidates this hash — nix-check.yml went red on the version commit and printed the value to use: recorded in nix/package.nix: sha256-1fer91zZlZxC5SoIj3F/bNcLoD+Q+QxLpCZF067Upko= expected from package-lock.json: sha256-Vr6Sw/WKmX22eT4a22+Xr3/miMzZr2uAwiYx12toU/E= Folded into this PR rather than left for the automation: bump-nix-package.yml ran green on the v1.9.6 release but opened no PR (it can only push a branch — the PR needs a token GITHUB_TOKEN does not have), so nothing was coming to fix it, and merging the bump alone would have left main red.
Summary
v1.9.6is tagged and building;mainwas still declaring1.9.5. This sets it to1.9.6— the same move asa0eca303after the previous release, and written by the same scriptpromote.ymlitself uses (.github/scripts/set-release-version.mjs), sopackage-lock.jsonis updated alongsidepackage.jsoninstead of being left behind.Why this isn't just merging #392
promote.ymlopened #392 (release/v1.9.6-sync→main) and failed to rebase-merge it after five attempts, with the advice "merge it by hand". It should be closed, not merged.release/v1.9.6was cut from the v1.9.5 tag, whose contentmainalready carries under different SHAs from the earlier rebase-merge. So the PR arrives with 39 commits, 23 of which are content-duplicates — which is why the rebase-merge could never land. And its net diff againstmainis a reversion:That is the entire updater stack, the editor's delete-project test, and 111 lines of
build.yml— everything that landed onmainafter v1.9.5 and was deliberately held out of the 1.9.6 patch release. The conflict was load-bearing; it stopped a silent revert.The version bump is the only part of #392 that
mainactually wants, and it is here.Related issue
Refs #385
Type of change
Release impact
Desktop impact
Screenshots / video
n/a
Testing
node .github/scripts/set-release-version.mjs 1.9.6— the scriptpromote.ymlruns. Verified all three version fields afterwards:No source change, so no test run is meaningful beyond CI. Note the lockfile version change is exactly what invalidates
nix/package.nix'snpmDepsHash;bump-nix-package.ymlopens that fix againstmainonrelease: published, as it does for every release.Summary by CodeRabbit