Skip to content

chore(release): set main to 1.9.6 - #393

Merged
EtienneLescot merged 2 commits into
mainfrom
claude/set-main-1-9-6
Aug 18, 2026
Merged

chore(release): set main to 1.9.6#393
EtienneLescot merged 2 commits into
mainfrom
claude/set-main-1-9-6

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

v1.9.6 is tagged and building; main was still declaring 1.9.5. This sets it to 1.9.6 — the same move as a0eca303 after the previous release, and written by the same script promote.yml itself uses (.github/scripts/set-release-version.mjs), so package-lock.json is updated alongside package.json instead of being left behind.

Why this isn't just merging #392

promote.yml opened #392 (release/v1.9.6-syncmain) and failed to rebase-merge it after five attempts, with the advice "merge it by hand". It should be closed, not merged.

release/v1.9.6 was cut from the v1.9.5 tag, whose content main already carries under different SHAs from the earlier rebase-merge. So the PR arrives with 39 commits, 23 of which are content-duplicates — which is why the rebase-merge could never land. And its net diff against main is a reversion:

electron/auto-updater.ts                     |  92 ------
electron/install-channel.ts                  | 146 ------
electron/update-checker.ts                   | 164 ------
scripts/mac-update-feed.mjs                  | 105 ------
.github/workflows/build.yml                  | 111 +-----
src/.../OpenProjectModal.test.tsx            |  79 ------
                46 files changed, 106 insertions(+), 1889 deletions(-)

That is the entire updater stack, the editor's delete-project test, and 111 lines of build.yml — everything that landed on main after v1.9.5 and was deliberately held out of the 1.9.6 patch release. The conflict was load-bearing; it stopped a silent revert.

The version bump is the only part of #392 that main actually wants, and it is here.

Related issue

Refs #385

Type of change

  • Bug fix
  • Feature
  • Enhancement
  • Documentation
  • Refactor / maintenance
  • Performance
  • Security

Release impact

  • Patch
  • Minor
  • Major / breaking change
  • No release note needed

Desktop impact

  • Windows
  • macOS
  • Linux
  • Installer / packaging
  • Not platform-specific

Screenshots / video

n/a

Testing

node .github/scripts/set-release-version.mjs 1.9.6 — the script promote.yml runs. Verified all three version fields afterwards:

package.json          : 1.9.6
package-lock.json root: 1.9.6
package-lock packages[""]: 1.9.6

No source change, so no test run is meaningful beyond CI. Note the lockfile version change is exactly what invalidates nix/package.nix's npmDepsHash; bump-nix-package.yml opens that fix against main on release: published, as it does for every release.

Summary by CodeRabbit

  • Chores
    • Updated the package to version 1.9.6.
    • Updated packaging metadata to reflect the current dependency set.

v1.9.6 is tagged and building; main was still declaring 1.9.5. Same move as
`a0eca303 chore(release): set main to 1.9.5` after the previous release, and
written by the same script promote.yml uses (.github/scripts/set-release-version.mjs),
so package-lock.json is updated alongside package.json rather than left behind.

This exists as its own commit because the sync PR that promote.yml opened (#392)
cannot do the job. That branch was cut from the v1.9.5 TAG, whose content main
already carries under different SHAs from the earlier rebase-merge, so the PR
carries 39 commits of which 23 are duplicates -- which is why the rebase-merge
failed five times. Worse, its net diff against main is a reversion: 1889
deletions taking out the whole updater stack (auto-updater, install-channel,
update-checker, mac-update-feed), the editor's OpenProjectModal test, and 111
lines of build.yml -- everything that landed on main after v1.9.5 and was
deliberately kept out of the 1.9.6 patch release. The conflict was load-bearing.

Closing #392 rather than merging it; this is the only part of it main wants.
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d2e3d0b6-bea7-465b-b3cb-7e5e20911970

📥 Commits

Reviewing files that changed from the base of the PR and between b2a4714 and 6cfbcfd.

📒 Files selected for processing (1)
  • nix/package.nix

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The package version in package.json was incremented from 1.9.5 to 1.9.6. The Nix package definition now uses an updated npmDepsHash.

Changes

Package release

Layer / File(s) Summary
Update release metadata
package.json, nix/package.nix
The package version changes to 1.9.6. The Nix package definition uses the updated npm dependency hash.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6cfbc

The PR only updates release metadata and the associated Nix dependency hash, with no source-behavior change. The hash is consistent with the lockfile and Nix validation, so no actionable merge-blocking risk remains beyond normal CI checks.

Possibly related PRs

Suggested reviewers: sepion02

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the release maintenance change and the target version.
Description check ✅ Passed The description covers the required sections and explains the version update, related issue, impact, and testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/set-main-1-9-6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Bumping the version rewrites package-lock.json, which is exactly what
invalidates this hash — nix-check.yml went red on the version commit and printed
the value to use:

  recorded in nix/package.nix:      sha256-1fer91zZlZxC5SoIj3F/bNcLoD+Q+QxLpCZF067Upko=
  expected from package-lock.json:  sha256-Vr6Sw/WKmX22eT4a22+Xr3/miMzZr2uAwiYx12toU/E=

Folded into this PR rather than left for the automation: bump-nix-package.yml
ran green on the v1.9.6 release but opened no PR (it can only push a branch —
the PR needs a token GITHUB_TOKEN does not have), so nothing was coming to fix
it, and merging the bump alone would have left main red.
@EtienneLescot
EtienneLescot merged commit 43517ac into main Aug 18, 2026
18 checks passed
@EtienneLescot
EtienneLescot deleted the claude/set-main-1-9-6 branch August 18, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant