Repository navigation
feat: add Dutch (nl) locale - #1391
Gryzze-CAW wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Dutch translation catalogs and checks src/i18n/locales/nl/*, src/i18n/__tests__/tutorialHelpTranslations.test.ts |
Adds Dutch translations for common actions, dialogs, editor, launch interface, settings, shortcuts, and timeline. The tutorial-help checks now include Dutch dialogs. |
Locale registration and distribution src/i18n/config.ts, electron/i18n.ts, electron-builder.json5, README.md, AGENTS.md |
Adds Dutch to the supported locale list, Electron message map and locale setter, and packaging language lists. Updates the README language list and locale-count references. |
Priority:
Estimated code review effort: 3 (Moderate) | ~25 minutes
Change: Feature
Possibly related issues
getopenscreen/openscreen#913: Dutch launch tooltip translations overlap with the issue’s scope, but the supplied context does not establish that this change fulfills its native-speaker review requirement.
Merge Risk: 
Minimal · up to e11ac
-
No actionable issue is established for the Dutch locale addition; it is ready to merge after normal checks.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Description check
-
Explanation
The description covers the required sections and provides clear implementation details, testing results, release impact, and known testing limitations. Screenshots are referenced as pending, but this is a minor omission for a localization change.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (10 skipped: 10 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Summary
Adds Dutch (
nl) as the 16th supported locale. All seven namespaces are translated (common, dialogs, editor, launch, settings, shortcuts, timeline) andnlis registered everywhere a locale list is read:SUPPORTED_LOCALES, the main-process mini-i18n, both language lists inelectron-builder.json5, and the dialogs map in the tutorial-help test. README and AGENTS.md list the new language and count.The folder is the bare tag
nl, so the renderer's base-language matching routes nl-NL and nl-BE to it.AI WAS USED to produce the first translation (Claude). A native Dutch (Flemish) speaker reviewed it in the running app.
Dutch-specific choices:
dialogs.tutorial.*fragments are cut to fit Dutch word order.explanationMiddlestarts with a full stop and no leading space, so the sentence reads "...die je wilt verwijderen. Alles wat bedekt is door een rood trimsegment, wordt...".effects.fitClipFewis filled in for key parity (Dutch has only one/other).Related issue
No existing issue or pull request for Dutch found.
Type of change
Release impact
Desktop impact
Screenshots / video
Editor in Dutch (browser mode,
?windowType=editor): screenshots to follow in a comment.Testing
npm run i18n:checkpasses: 15 locales match en across 7 namespaces, 16 SUPPORTED_LOCALES align with appx.languages and electronLanguages.npx vitest run src/i18npasses (129 tests, including localeParity and tutorialHelpTranslations fornl).npx tsc --noEmitandbiome checkon the changed files pass.NO_ELECTRON=1 npm run devand checked the editor, panels and timeline in Dutch in the browser.Summary by CodeRabbit
New Features
Documentation