Skip to content

fix(#642): preload bindings should only set value on first load#643

Open
garethbowen wants to merge 2 commits intomainfrom
642-preload-set-on-edit
Open

fix(#642): preload bindings should only set value on first load#643
garethbowen wants to merge 2 commits intomainfrom
642-preload-set-on-edit

Conversation

@garethbowen
Copy link
Collaborator

Closes #642

I have verified this PR works in these browsers (latest versions):

  • Chrome
  • Firefox
  • Safari (macOS)
  • Safari (iOS)
  • Chrome for Android
  • Not applicable

What else has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

What's changed

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2026

🦋 Changeset detected

Latest commit: d7beeaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@getodk/xforms-engine Patch
@getodk/scenario Patch
@getodk/web-forms Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@latin-panda latin-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

);
const originalValue = scenario.answerOf('/data/element').toString();

const edited = await scenario.proposed_editCurrentInstanceState(); // TODO rename this stupid function
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this name isn't clear, what about: createFormEditInstance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preload values should only be set during first load

2 participants