Make sure that negative integers are correctly rejected; fixes #615

[liuzicheng1987]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @liuzicheng1987, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the JSON deserializer incorrectly allowed negative integer values to be parsed into unsigned integer types. By switching to a more appropriate validation function and adding dedicated tests, the change enhances type safety and prevents potential data corruption or unexpected behavior when handling numerical data.

Highlights

• Corrected Unsigned Integer Validation: The JSON reader now correctly uses yyjson_is_uint to validate unsigned integer types, ensuring that negative values are properly rejected during deserialization.
• Improved Error Messaging: The error message for casting to unsigned integers has been updated to reflect the specific type of validation failure.
• Added Regression Tests: New tests were introduced to specifically verify that negative integer inputs are rejected when attempting to deserialize into std::uint64_t and std::atomic<std::uint64_t>.

Changelog

• include/rfl/json/Reader.hpp
  • Changed the validation function for unsigned integer types from yyjson_is_int to yyjson_is_uint.
  • Updated the error message when casting to an unsigned integer fails.
  • Applied minor formatting to a std::string_view initialization.
• tests/json/test_atomic_negative.cpp
  • Added a new test file to verify that negative integers are correctly rejected when deserializing into std::uint64_t and std::atomic<std::uint64_t>.

Activity

• The pull request was opened by liuzicheng1987 to fix issue std::atomic<T> Reflector bypasses domain validation present on bare T (#575 followup) #615, addressing incorrect handling of negative integers for unsigned types.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where negative integers were not correctly rejected when deserializing into unsigned integer types. The fix involves changing the check from yyjson_is_int to the more specific yyjson_is_uint in the JSON reader, which correctly identifies and rejects negative values for unsigned types. The corresponding error message has also been updated for clarity. Additionally, a new test case has been added to verify this fix for both standard and atomic unsigned integers, ensuring that such invalid inputs are properly handled and result in a deserialization error as expected. The changes are correct and well-tested.