Skip to content

Comments

Fix: exclude nones when creating a record#371

Merged
annvelents merged 2 commits intomainfrom
fix/create-with-none
Feb 19, 2026
Merged

Fix: exclude nones when creating a record#371
annvelents merged 2 commits intomainfrom
fix/create-with-none

Conversation

@annvelents
Copy link
Contributor

@annvelents annvelents commented Feb 18, 2026

we already have exclude none in update mixin, but customer update uses upsert, so we're using create customer mixin, as result, Nones are being sent unless values are prefetched when updating a cusotmer and in the service we only check if key present in params, not value

so there is a case where

  • a customer is created without currency
  • later customer gets a subscription -> it sets customer'scurrency
  • later update of the customer with only name tries to set customer.currency to nil, which results in 422

@annvelents annvelents changed the title exclude nones when creating a record Fix: exclude nones when creating a record Feb 18, 2026
@annvelents annvelents merged commit 8990914 into main Feb 19, 2026
7 checks passed
@annvelents annvelents deleted the fix/create-with-none branch February 19, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants