Skip to content

docs(progress): correct the PR #90 stack record - #91

Merged
getdownandcode merged 1 commit into
mainfrom
docs/progress-pr90-review-fix
Oct 27, 2026
Merged

getdownandcode merged 1 commit into
mainfrom
docs/progress-pr90-review-fix

Conversation

@getdownandcode

Copy link
Copy Markdown
Owner

Summary

One-commit follow-up to PR #90 (merged ef99cf0..713735b). The review-fix commit 713735b ("fix(deploy): report malformed Redis URLs instead of crashing") landed after the stack was recorded, so docs/PROGRESS.md still described PR #90 as five layer commits plus one progress-bookkeeping commit (6 total) while the merged PR carries 7.

This corrects the record:

  • Follow-up section PR line now counts five layer commits plus one review-fix and one progress-bookkeeping commit; Commits notes 6 including the review fix.
  • The #86 entry documents the additional hardening: apply_redis_password() splits REDIS_URL with urlsplit() before the audit parses anything, so _resolve_redis_url() catches that ValueError (malformed IPv6 authority such as redis://[broken) and reports an invalid URL instead of crashing.

Test plan

pytest -q tests/unit/test_docs_accuracy.py   # 8 passed
ruff check .                                 # All checks passed
ruff format --check docs/PROGRESS.md         # already formatted

Doc-only change; no behavior difference.

The review-fix commit 713735b was added after the PR #90 stack was recorded, so the follow-up section still described the PR as five layer commits plus one progress-bookkeeping commit (6 total) while the PR carries 7. Update the PR line and commit count to include the review fix, and note in the #86 entry that _resolve_redis_url() also hardens the Redis URL-splitting path per the Codex finding.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T17:23:23.658211Z d21283c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@getdownandcode
getdownandcode merged commit 486894b into main Oct 27, 2026
4 checks passed
@getdownandcode
getdownandcode deleted the docs/progress-pr90-review-fix branch October 27, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant