Repository navigation
docs(progress): correct the PR #90 stack record - #91
Merged
Merged
Conversation
The review-fix commit 713735b was added after the PR #90 stack was recorded, so the follow-up section still described the PR as five layer commits plus one progress-bookkeeping commit (6 total) while the PR carries 7. Update the PR line and commit count to include the review fix, and note in the #86 entry that _resolve_redis_url() also hardens the Redis URL-splitting path per the Codex finding.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-commit follow-up to PR #90 (merged
ef99cf0..713735b). The review-fix commit713735b("fix(deploy): report malformed Redis URLs instead of crashing") landed after the stack was recorded, sodocs/PROGRESS.mdstill described PR #90 as five layer commits plus one progress-bookkeeping commit (6 total) while the merged PR carries 7.This corrects the record:
Commitsnotes 6 including the review fix.#86entry documents the additional hardening:apply_redis_password()splitsREDIS_URLwithurlsplit()before the audit parses anything, so_resolve_redis_url()catches thatValueError(malformed IPv6 authority such asredis://[broken) and reports an invalid URL instead of crashing.Test plan
Doc-only change; no behavior difference.