Repository navigation
fix(tools): preserve $defs in generated tool schemas - #81
Closed
HamzaKhanBUIC wants to merge 1 commit into
Closed
HamzaKhanBUIC wants to merge 1 commit into
HamzaKhanBUIC wants to merge 1 commit into
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70.
Preserves $defs and �dditionalProperties in create_tool_schema, preventing unresolvable $ref dangling pointers when tools use Enum or nested BaseModel parameters.
Problem
When constructing tool parameters, create_tool_schema extracted only properties and
equired from Pydantic's model_json_schema(). Nested models and enums are emitted by Pydantic as $ref: #//..., but the $defs block was dropped. This left emitted schemas with unresolvable references, causing LLM providers (e.g. OpenAI, Gemini) to reject or fail to interpret tool definitions.
Solution
aw_json_schema[$defs] in parameters[$defs] when present.
aw_json_schema[additionalProperties] in parameters[additionalProperties] when present.
ead_file, http_fetch, sql_readonly, web_search) produce expected schemas with no unnecessary keys.
Verification
uv run pytest tests/unit/test_tool_schema.py-> 6/6 passeduv run ruff check .-> All checks passeduv run ruff format --check .-> 110 files already formatteduv run mypy agentkit tests/unit/test_tool_schema.py-> Success: no issues found in 43 source files