Repository navigation
fix(gemini): exclude thought parts from the model answer - #78
Closed
HamzaKhanBUIC wants to merge 1 commit into
Closed
HamzaKhanBUIC wants to merge 1 commit into
HamzaKhanBUIC wants to merge 1 commit into
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #63 (AUDIT-06: High/Medium — Gemini thought parts are appended to the answer).
Problem
In agentkit/llm/gemini.py, the candidate parts loop appended part.text to text_parts without checking the thought flag on types.Part. This caused internal chain-of-thought reasoning to be concatenated into LLMResponse.text, leaking into assistant turns, persisted history, and the API final_answer.
Changes
Verification