Repository navigation
fix(sql): enforce a real server-side row cap - #77
Closed
HamzaKhanBUIC wants to merge 1 commit into
Closed
HamzaKhanBUIC wants to merge 1 commit into
HamzaKhanBUIC wants to merge 1 commit into
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59 (AUDIT-02: Critical — \LIMIT ALL\ / huge limits bypass the row cap).
Problem
Previously, _apply_row_limit\ checked for any occurrence of \LIMIT\ or \FETCH FIRST\ in the trailing clause of the statement and returned the query completely untouched. As a result:
ow_limit\ (e.g. \LIMIT 1000000000) were not clamped;
Changes
ow_limit\ are clamped down to
ow_limit; smaller limits are preserved.
Verification
uff check .: clean (0 errors).
uff format --check .: clean (110 files formatted).