Repository navigation
fix(auth): compare API keys in constant time - #76
Closed
HamzaKhanBUIC wants to merge 2 commits into
Closed
HamzaKhanBUIC wants to merge 2 commits into
HamzaKhanBUIC wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74
Summary of Changes
agentkit/api/auth.py): Replaced the short-circuitingapi_key not in settings.api_keys_listcheck with constant-time comparison (hmac.compare_digest) across all configured keys to eliminate byte-by-byte timing oracles.api_key.strip()) identical toSettings.api_keys_list, ensuring that whitespace-padded keys (e.g.' key ') resolve identically to unpadded keys and that consistent keys are used for downstream rate-limiting and logging.TypeErrorcrashes when unauthenticated clients or fuzzers submit non-ASCII / Unicode payloads.tests/unit/test_api_auth.pyasserting whitespace-padded keys, whitespace-only keys, invalid keys, and Unicode key support.test_api_key_auth_endpoint_integrationverifying identical HTTP 200 responses for padded headers.ruff check .,ruff format --check ., andmypy agentkit/api/auth.pyall clean.