Skip to content

Upgrade kmp and java apps to use 5.0.0-preview.3#186

Merged
Ben Chatelain (phatblat) merged 20 commits intomainfrom
ben/kotlin-java-5.0-preview.3
Nov 6, 2025
Merged

Upgrade kmp and java apps to use 5.0.0-preview.3#186
Ben Chatelain (phatblat) merged 20 commits intomainfrom
ben/kotlin-java-5.0-preview.3

Conversation

@phatblat
Copy link
Member

@phatblat Ben Chatelain (phatblat) commented Oct 6, 2025

This PR updates the Java Server and Kotlin Multiplatform Quickstart apps to use Ditto 5.0.0-preview.3.

Other Changes

  • Renamed java-spring/ to java-server/
  • Added java-server/java-spring-maven/ subproject for testing Maven compatibility

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Upgrades Kotlin Multiplatform and Java applications to use Ditto SDK version 5.0.0-preview.3, updating the API implementation to match the new SDK interface.

  • Updated Ditto SDK version from 5.0.0-preview.1 to 5.0.0-preview.3
  • Migrated from DittoIdentity-based authentication to new authentication provider pattern
  • Changed API method calls to use new naming conventions (e.g., registerObserver to observe, getString to asString)

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
kotlin-multiplatform/composeApp/build.gradle.kts Updated Ditto dependency versions to 5.0.0-preview.3
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt Refactored Ditto initialization to use new authentication pattern and updated API calls
kotlin-multiplatform/composeApp/src//kotlin/com/ditto/quickstart/ditto/DittoManager..kt Updated platform-specific Ditto creation to use DittoFactory
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/data/DittoCredentials.kt Added new data class for Ditto credentials
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/di/DittoModule.kt Updated dependency injection to include credentials
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/data/repository/DittoTaskRepository.kt Updated API method call from registerObserver to observe
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ui/TaskAddEditScreen.kt Minor UI layout adjustment
kotlin-multiplatform/README.md Updated API reference link to preview.3 version
java-spring/src/main/java/com/ditto/example/spring/quickstart/service/DittoService.java Migrated to new authentication pattern and updated transport configuration
java-spring/src/main/java/com/ditto/example/spring/quickstart/service/DittoTaskService.java Updated API method calls to use new naming conventions
java-spring/build.gradle.kts Updated Ditto dependency versions to 5.0.0-preview.3
java-spring/java-spring-maven/pom.xml Added Maven configuration with preview.3 dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@phatblat Ben Chatelain (phatblat) force-pushed the ben/kotlin-java-5.0-preview.3 branch from f133c2f to f7377a2 Compare October 14, 2025 23:53
@phatblat Ben Chatelain (phatblat) requested a review from a team as a code owner October 14, 2025 23:55
@phatblat Ben Chatelain (phatblat) force-pushed the ben/kotlin-java-5.0-preview.3 branch 5 times, most recently from 1990e36 to b9055f9 Compare October 17, 2025 22:49
Copy link

@russhwolf Russell Wolf (russhwolf) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the expected status of tests? The browserstack CI failure also happens for me locally, and I have similar failures in both the Android and iOS integration tests which are not being run in CI.

Otherwise, mostly nits here.

Copy link

@russhwolf Russell Wolf (russhwolf) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to approve after in-person convo that we haven't been maintaining those tests. We should probably update them at some point but I don't want to gatekeep this PR on that.

@phatblat Ben Chatelain (phatblat) force-pushed the ben/kotlin-java-5.0-preview.3 branch from 9549e56 to 9210e42 Compare November 5, 2025 15:53
@phatblat Ben Chatelain (phatblat) added the enhancement New feature or request label Nov 6, 2025
@phatblat Ben Chatelain (phatblat) enabled auto-merge (squash) November 6, 2025 12:50
@phatblat Ben Chatelain (phatblat) merged commit 533e6b2 into main Nov 6, 2025
14 checks passed
@phatblat Ben Chatelain (phatblat) deleted the ben/kotlin-java-5.0-preview.3 branch November 6, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants