Skip to content

fix(codeburn): restore menubar project token reporting#565

Open
zorgy13 wants to merge 1 commit into
getagentseal:mainfrom
zorgy13:codex/please-implement-this-plan-codeburn-rebased
Open

fix(codeburn): restore menubar project token reporting#565
zorgy13 wants to merge 1 commit into
getagentseal:mainfrom
zorgy13:codex/please-implement-this-plan-codeburn-rebased

Conversation

@zorgy13

@zorgy13 zorgy13 commented Jun 23, 2026

Copy link
Copy Markdown

Summary

  • group duplicate menubar project rows while preserving real token totals
  • expose project/session token totals through the menubar JSON and backward-compatible Swift decoder
  • add a menubar smoke script and verification notes for the CodeBurn restore path

Verification

  • npm test -- tests/menubar-json.test.ts tests/providers/codex.test.ts tests/usage-aggregator.test.ts
  • npm run build
  • cd mac && swift build
  • mac/Scripts/smoke-popover.sh /Users/vadimirrosman/Documents/Codex/2026-06-23/new-chat-4/outputs/codeburn-menubar-smoke-rebased-20260623T1432Z
  • npx vitest tests/cli-export-date-range.test.ts tests/cli-json-daily.test.ts tests/cli-status-menubar.test.ts tests/parser-proxy-codex-only.test.ts --testTimeout 30000 --fileParallelism=false

Note: swift test is blocked in this local toolchain by no such module Testing before task tests run. Full parallel npm test hit 5000ms timeouts in four heavy CLI test files; those files pass when rerun sequentially with a 30000ms timeout.

@ozymandiashh ozymandiashh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — restoring accurate per-project token totals in the menubar is a real improvement.

Status: needs a rebase before review/merge — it currently conflicts with main. The menubar surface was reworked heavily after this PR's base (2026-06-23), and every core file this PR touches has changed since:

  • src/menubar-json.ts and tests/menubar-json.test.ts (2 commits each)
  • src/usage-aggregator.ts, mac/.../Data/MenubarPayload.swift, mac/.../CodeBurnApp.swift

Relevant landings include #549 (show every active agent as a tab), #567/#568 (combined multi-device usage in menubar-json), and #598 (menubar plan tab / model-scoped limits).

It's not superseded — I don't see the duplicate-project-row grouping or the project/session token totals in menubar-json on main today — but before a full review please:

  1. Rebase onto current main and resolve the menubar-json.ts / usage-aggregator.ts / MenubarPayload.swift conflicts against the new shape of those files.
  2. Re-confirm the problem still reproduces after the rework — some of the row-duplication behavior may interact with the new per-agent tab / combined-usage code, so a fresh before/after (the smoke-popover.sh you added is perfect for this) would help.
  3. Keep the Swift decoder change backward-compatible with the current MenubarPayload schema on main (it moved).

Once rebased + CI-green I'll run the full adversarial review. Thanks for the smoke script and verification notes — that's exactly the right instinct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants