Remove console mode from GUI executable#43
Open
philpem wants to merge 4 commits intogeraldholdsworth:mainfrom
Open
Remove console mode from GUI executable#43philpem wants to merge 4 commits intogeraldholdsworth:mainfrom
philpem wants to merge 4 commits intogeraldholdsworth:mainfrom
Conversation
The CLI functionality is now provided by the standalone DiscImageManagerCLI binary, eliminating code duplication between the GUI console mode and CLI. Changes: - Remove ConsoleAppUnit.pas from GUI project - Remove MainUnit_Console.pas include from MainUnit.pas - Remove ParseCommand declaration from TMainForm - Remove CheckConsole call from main program - Update project file to remove ConsoleAppUnit Users wanting command-line access should use the separate CLI build which doesn't require X11/GUI dependencies. https://claude.ai/code/session_01H1suvkNPi2MVsX1y9Qy86P
- Delete ConsoleAppUnit.pas (no longer used by GUI) - Delete MainUnit_Console.pas (no longer used by GUI) - Remove console fallback in ReportError that used cmdRed/cmdNormal - Simplify ReportError to always use GUI dialogs The CLI functionality is now provided by the standalone DiscImageManagerCLI binary. These old console mode files are no longer needed. https://claude.ai/code/session_01H1suvkNPi2MVsX1y9Qy86P
Remove ConsoleAppUnit dependency and all console output code paths that used ANSI color codes (cmd* variables). The GUI build no longer has embedded console mode, so this unit now operates purely in GUI mode. https://claude.ai/code/session_01H1suvkNPi2MVsX1y9Qy86P
philpem
changed the title
philpem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the changes from #42 and also removes the console mode code from the GUI.
I've made it a separate PR so we can decide separately if we want to go down this route. See #42 for more info on the main changes.
The advantage is this gives us two executables with a clear separation of roles - if you want to run commands from the command-line, you run
DiscImageManagerCLI- otherwise you runDiscImageManager.This also means there's no need for the GUI/console detection code which is currently causing issues on Linux (it seems to always think it's in console mode, but can be overridden with
DiscImageManager -g)If this gets merged, #42 needs to go first, probably as a squash merge to avoid cluttering the change history.