Skip to content

Remove mode selector from repeat_after options flow#35

Merged
gensyn merged 3 commits intomainfrom
copilot/remove-modal-option-repeat-after
Apr 15, 2026
Merged

Remove mode selector from repeat_after options flow#35
gensyn merged 3 commits intomainfrom
copilot/remove-modal-option-repeat-after

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

  • Fix _find_most_recent_occurrence in coordinator.py to respect weeks_interval for CONF_REPEAT_EVERY_WEEKDAY
    • Added _calc_most_recent_weekday_in_cycle instance method that anchors to last_done, computes the first cycle date, then finds the largest N such that first_cycle + N*weeks_interval weeks ≤ today
    • Updated _find_most_recent_occurrence to call this instead of _calc_most_recent_weekday for the weekday sub-type
  • Added regression test test_repeat_every_weekday_mark_as_done_respects_weeks_interval for the exact scenario from the problem statement (every 3 weeks on Tuesday, 7 weeks overdue → lands on week-6 cycle date, not latest Tuesday)
  • All 248 unit tests pass

@gensyn gensyn marked this pull request as ready for review April 15, 2026 09:37
@gensyn gensyn merged commit 04f69fb into main Apr 15, 2026
5 checks passed
@gensyn gensyn deleted the copilot/remove-modal-option-repeat-after branch April 15, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants