fix: intrinsic tests and add some safeguards for future adapters changes #1078
Open
jakelorocco wants to merge 3 commits into
Open
fix: intrinsic tests and add some safeguards for future adapters changes #1078jakelorocco wants to merge 3 commits into
jakelorocco wants to merge 3 commits into
Conversation
…nsics Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
…ests; small nits Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
jakelorocco
force-pushed
the
test/fix-intrinsic-tests
branch
from
84f4af5 to
33401f4
Compare
Contributor
Author
|
@frreiss, this PR will require your review when you get a chance. Thank you. I think the main part is to make sure I added support for req-check and certainty correctly. I think I have previously mentioned the versioning checks to you. |
jakelorocco
changed the title
jakelorocco
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Link to Issue: Fixes update intrinsic tests #1029
Adds back the uncertainty and requirement-check tests
Adds last_validated_commit for adapters we test for so that we can catch future version changes in our nightlies
Testing
Attribution