Repository navigation
Conversation
…?url= genclass.dev/scan now opens the whole report to any signed-in account (the owner's call, 2026-11-13, genclass-site PR on deploy/scan-page-light). Its "Sign in to see it all" and "Create a free account" buttons go to /login and /signup with ?next=/scan?url=<encoded page>. safeNext refused that, so people landed on /account instead of back on the report. It now also allows /scan, or /scan?url= followed by up to 280 URL-safe characters (no &, #, quotes or angle brackets); every other next is refused as before. Tests: telemetry-worker 873 of 873; strict typecheck clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
genclass.dev/scan now shows the whole report to any signed-in account (genclass-dev/genclass-site#56). Its "Sign in to see it all" and "Create a free account" buttons send people to
/loginand/signupwith?next=/scan?url=<encoded page>. ButsafeNextonly allowed/account…and/login/device, so after signing in people landed on /account instead of back on the report.safeNextnow also allows:/scan/scan?url=followed by 1 to 280 URL-safe characters (letters, digits,% . _ ~ ! * ' ( ) / : + -)It still refuses
&,#, quotes, angle brackets, other query keys, other paths (/scanner,/scan/../account) and anything over 300 characters. All the existing sign-in paths (password, passkey, Google, GitHub, and an already signed-in visit to /login) already run theirnextthroughsafeNext, so nothing else changes.Checks
cd telemetry-worker && npx vitest run --maxWorkers=2: 873 of 873. ThesafeNexttest gains 3 good and 9 bad/scancases.telemetry-worker/src/index.tsis clean.Not deployed. It can ride with the next collector deploy. The scanner change works without it: until this ships, signing in from a report just lands on /account.
🤖 Generated with Claude Code