Repository navigation
fix(ui): align source permission modal with permission editors - #199
Merged
Merged
Conversation
- replace the select + checkbox controls with AccessLevelPicker-style radio cards and Switch rows matching ConnectionPermissionEditor - restore the destructive detach affordance and inline footer confirm - resolve cancel copy through common.buttons.cancel - drop orphaned aiPermissions/modifySource keys and update the modal test
Blankll
force-pushed
the
codex/permission-controls-consistency
branch
from
October 28, 2026 07:46
0d939a8 to
16cd1b4
Compare
Blankll
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the Data Studio Modify Datasource dialog with the existing permission editors. Use mode cards and action switches while retaining the effective-access summary, save/retry behavior, and explicit detach confirmation.
Validation:
npm test: 855 tests passed.npm run buildpassed.npm run lint:checkpassed.