Repository navigation
fix: restore permission recovery and consistent connection controls - #197
Merged
Merged
Conversation
…n editing - access levels use the shared radio pattern with a short scope description inside each option; Custom edits the same values as the presets instead of forming a separate layer - connection-level custom actions expose Use default (Allow/Deny); system defaults use switches for binary actions - MCP service settings and shared AI defaults live in separate cards - per-connection permission editing requires the local Ultimate entitlement: inline upgrade prompt, draft stripped on save, and save_ai_permissions enforced in Rust with a cleanup carve-out that only clears decisions of connections that no longer exist
Option containers keep only their title so the picker takes roughly half the height in the connection dialog; a single short description below the group follows the selected access level and serves as the shared aria-describedby target.
The test's loop token accounting rebuilt the o200k_base encoder for every counted message, which can exceed the 10s loop timeout on CI runners (ubuntu failed on 4 consecutive commits). Use an Anthropic-family model so counting takes the cheap character heuristic, and give the test its own session id so the per-session tokenizer cache cannot pin another family.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data Studio permission denials could appear as muted activity, and reopening a conversation reconstructed failed or rejected calls as successful. The agent could also continue after a blocked action without a clear recovery state. Connection editing expanded legacy SSH settings inline instead of using the existing compact tunnel-item pattern.
This change:
Validation:
Already dispatched work is not undone. Legacy history whose permission source was never recorded shows a generic permission reason.