Skip to content

Skip standard_conforming_strings=off specs on PostgreSQL-19 #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larskanis merged 1 commit into from
Oct 19, 2026
Merged

Skip standard_conforming_strings=off specs on PostgreSQL-19 #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions spec/pg/connection_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3063,12 +3063,20 @@ def embed_params_and_check(sql, params, conn: @conn)
end

def with_std_conf_strings(conn, onoff)
conn.exec("SET standard_conforming_strings = #{onoff}")
conn.exec("SET escape_string_warning = #{onoff}")
yield
ensure
conn.exec("SET standard_conforming_strings = on")
conn.exec("SET escape_string_warning = on")
# PostgreSQL-19 rejects standard_conforming_strings=off and removed escape_string_warning
if conn.server_version >= 190000
skip "standard_conforming_strings=off is not supported by the server" if onoff == "off"
return yield
end

begin
conn.exec("SET standard_conforming_strings = #{onoff}")
conn.exec("SET escape_string_warning = #{onoff}")
yield
ensure
conn.exec("SET standard_conforming_strings = on")
conn.exec("SET escape_string_warning = on")
end
end

it "ensures PostgreSQL string syntax does not change" do
Expand Down
Loading