Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA. |
The composer knew one card wiring, SD_MMC 1-bit on the SDMMC host. The Waveshare RGB boards (the 7-inch, the 4.3B) put the card on SPI2 with its chip-select on the CH422G, so no composed definition could declare their slot. storage.microSD.interface now takes "spi" beside "sdmmc-1bit": spiHost (spi2 or spi3), maxFreqKhz (default 20000), the mosi/miso/sck pins and one select line, either pins.cs on a GPIO or chips.expander.outputs.cardSelect on the expander. Both or neither is an error, as is a cardSelect with no storage, and the bus pins join the GPIO conflict table. The board header gains GEA_BOARD_MICROSD_SPI, an SdSpiConfig storageSpi constant and a cardSelect member on IoExpanderConfig; the SD_MMC constants stay, wired to GPIO_NUM_NC, because the base checks them. The CMake fragment names the interface and asks for esp_driver_sdspi and esp_driver_spi. The matching mount lives in @geastack/targets. Tested in test/boards.test.mjs (header, CMake, both select styles, the error cases, a lane clash) and documented in the setup guide's composed targets section. Verified on a Waveshare ESP32-S3-Touch-LCD-4.3B.
scottvr
force-pushed
the
composed-spi-microsd
branch
from
October 16, 2026 10:49
e392453 to
1949183
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[This PR is a sibling to @geastack/targets PR#6; it can be merged on its own, but won't be useful until the targets PR for SPI MicroSD is also in.]
The composer knew one card wiring, SD_MMC 1-bit on the SDMMC host. The Waveshare RGB boards (the 7-inch, the 4.3B) put the card on SPI2 with its chip-select on the CH422G, so no composed definition could declare their slot. storage.microSD.interface now takes "spi" beside "sdmmc-1bit": spiHost (spi2 or spi3), maxFreqKhz (default 20000), the mosi/miso/sck pins and one select line, either pins.cs on a GPIO or chips.expander.outputs.cardSelect on the expander. Both or neither is an error, as is a cardSelect with no storage, and the bus pins join the GPIO conflict table.
The board header gains GEA_BOARD_MICROSD_SPI, an SdSpiConfig storageSpi constant and a cardSelect member on IoExpanderConfig; the SD_MMC constants stay, wired to GPIO_NUM_NC, because the base checks them. The CMake fragment names the interface and asks for esp_driver_sdspi and esp_driver_spi. The matching mount lives in @geastack/targets.
Tested in test/boards.test.mjs (header, CMake, both select styles, the error cases, a lane clash) and documented in the setup guide's composed targets section. Verified on a Waveshare ESP32-S3-Touch-LCD-4.3B.