Repository navigation
Preserve bookmarks and justified spacing for styled words - #74
Closed
gaspardpetit wants to merge 3 commits into
Closed
gaspardpetit wants to merge 3 commits into
gaspardpetit wants to merge 3 commits into
Conversation
gaspardpetit
added this pull request to stack #75
October 21, 2026 03:12
gaspardpetit
force-pushed
the
fix/migradoc-styled-word-review
branch
from
October 21, 2026 03:16
d1a4905 to
f2643da
Compare
Owner
Author
|
There are too many side effects and edge cases, this is on hold. See gaspardpetit/Pdfxport.Net#70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep Latin words together when styled text runs split them, including accented letters, contractions, and terminal punctuation. Move a leading bookmark with its word. Decide whether the group can move using the continuation line's effective indent, justified-space contraction, current-line leading kerning, and applicable terminal overhang.
This follows the styled-word fix in #8 and the area-continuation fix in #73. Mirrors the review corrections in Pdfxport #70.
Regressions cover each case. MigraDoc.Tests on .NET 8: 510 passed, 17 skipped. MigraDoc.Rendering netstandard2.0 build passed. The two changed files match Pdfxport #70 exactly.