Repository navigation
Stop the sync failing on every new folder Michael adds - #7
Merged
Merged
Conversation
The check failed every run from 2026-10-26 because Michael added mirror-assets/, six README SVGs. Listing every allowed top-level entry breaks on each harmless folder. Look instead for the default locations of the component types in Cursor's plugin schema that .apm/ does not cover: rules, commands, hooks, and MCP servers. Declared components were already caught by the manifest key check.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change narrowing upstream sync validation to unsupported plugin components.
No open issues 🎉
What changed in this PR
Updates upstream sync validation so decorative folders such as mirror-assets/ no longer fail the workflow, while retaining checks for plugin components that .apm/ does not cover.
Changes:
- Replaces the top-level allowlist with explicit checks for
rules,commands,hooks,mcp.json, and.mcp.json. - Leaves existing manifest validation and agent-copy consistency checks unchanged.
| File | Description |
|---|---|
.github/workflows/sync.yml |
Narrows validation to unsupported plugin component paths, allowing unrelated top-level additions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync has failed every day since 2026-10-26. Michael added
mirror-assets/, six SVGs for his README, and the last check rejects any top-level entry missing from its allowlist. The merge and push still happen before that check, so the fork kept up to 0.15.34, but each run went red.This swaps the allowlist for a short list of things that would actually break us: the default locations of the plugin component types in Cursor's plugin schema that
.apm/doesn't cover (rules,commands,hooks,mcp.json,.mcp.json). Decorative folders no longer fail the run. A component declared in a manifest is still caught by the existing key check, and a stale.apm/agentscopy by the existingdiff.I ran the step's script against six trees:
main(hasmirror-assets/)rules/x.mdc.mcp.jsonhooks.apm/agentsstaleactionlintpasses andautoreview(Codex) found nothing.