fix: let /review satisfy ship readiness gate#387
Merged
Conversation
- Add Step 5.8 to /review: persist review outcome to review log - Update shared REVIEW_DASHBOARD resolver: accept both `review` and `plan-eng-review` as valid Eng Review sources - Update ship abort text to mention both review options - Add 4 validation tests for persistence, propagation, and abort text Based on PR #338 by @malikrohail. DRY improvement per eng review: updated shared resolver instead of creating duplicate. Refs #280.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
garrytan
added a commit
that referenced
this pull request
Mar 26, 2026
* fix: let /review satisfy ship readiness gate (#280) - Add Step 5.8 to /review: persist review outcome to review log - Update shared REVIEW_DASHBOARD resolver: accept both `review` and `plan-eng-review` as valid Eng Review sources - Update ship abort text to mention both review options - Add 4 validation tests for persistence, propagation, and abort text Based on PR #338 by @malikrohail. DRY improvement per eng review: updated shared resolver instead of creating duplicate. Refs #280. * chore: bump version and changelog (v0.11.7.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/reviewnow persists its outcome to the review log (Step 5.8), so/shiprecognizes it as a valid Eng Review sourcereview(diff-scoped) andplan-eng-review(plan-stage) as valid Eng Review sources/reviewand/plan-eng-reviewwhen Eng Review is missingBased on PR #338 by @malikrohail. DRY improvement per eng review: updated the shared
REVIEW_DASHBOARDresolver instead of creating a duplicate ship-only resolver.Refs #280. Supersedes #338.
Test Coverage
4 new validation tests:
dashboard treats review as a valid Eng Review source— verifies ship/SKILL.mdshared dashboard propagates review source to plan-eng-review— verifies all dashboards/review persists a review-log entry for ship readiness— verifies Step 5.8/ship gate suggests /review or /plan-eng-review— verifies abort textPre-Landing Review
No issues found. Narrow template + generator change.
TODOS
No TODO items completed in this PR.
Test plan
🤖 Generated with Claude Code