Skip to content

remove persona mapping functionality from core product#469

Open
VelmiraS wants to merge 1 commit into
gardener:masterfrom
VelmiraS:remove-persona-mapping
Open

remove persona mapping functionality from core product#469
VelmiraS wants to merge 1 commit into
gardener:masterfrom
VelmiraS:remove-persona-mapping

Conversation

@VelmiraS

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Removes persona mapping from Docforge. Persona mapping is a Gardener-specific feature that assigns content to personas (Users, Operators, Developers) based on directory names (usage/, operations/, development/). It was introduced for the Gardener website and does not belong in the generic core — teams adopting docforge for their own pipelines encounter unexpected behavior tied to Gardener's internal documentation structure.

Changes

Deleted:

  • pkg/manifestplugins/persona/ — entire package removed
  • pkg/nodeplugins/persona/ — entire package removed
  • cmd/persona/option.go — configuration type removed
  • docs/plugin/persona.md — documentation removed

Modified:

  • cmd/app/cmd.go — removed persona.Persona import and struct field from options
  • cmd/app/flags.go — removed --persona-filter-enabled flag
  • cmd/app/exec.go — removed persona plugin wiring from manifest and node plugin stages
  • test/e2e/docforge_config.yaml — removed persona-filter-enabled key

Which issue(s) this PR fixes:

Fixes #464

Special notes for your reviewer:

No behavior regressions. Verified with a full e2e run against the Gardener documentation manifest: 803 document tasks, 430 download tasks processed, exit code 0. The --persona-filter-enabled flag now correctly returns unknown flag.

Release note:

Persona mapping functionality has been removed from the core product. The `--persona-filter-enabled` flag is no longer available. This feature was Gardener-specific and did not belong in the generic docforge core.

Persona mapping is highly deployment-specific and was introduced
for the Gardener website only. It does not belong in the generic
docforge core. Remove all related logic, configuration, and tests.

Relates-to: gardener#464
@gardener-prow

gardener-prow Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radabdimitrova for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jun 15, 2026
@VelmiraS

Copy link
Copy Markdown
Contributor Author

The CI failure is not related to the changes in this PR. The integration-test workflow requires id-token: write permission which is not available for PRs from forks — this is a GitHub security restriction. Could you please re-trigger the workflow or confirm that the failure is expected for external contributors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Gardener-Specific Persona Mapping

1 participant