Experimental IGS fix#129
Draft
stertooy wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 56.39% 57.00% +0.60%
==========================================
Files 87 87
Lines 12697 12770 +73
==========================================
+ Hits 7161 7279 +118
+ Misses 5536 5491 -45
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix #76 and #117 by fixing the igs algorithms. It would be much better to use Max Mayer's algorithms, but in the meantime perhaps this is worth considering?
The basic idea is that, in the current igs algorithms we do things like
which causes errors, because the group generated by
kandlmight be strictly contained inside the group generated bygandh. Instead, while performing the Euclidean algorithm on the leadining exponents, we multiplygandhat the same time. Essentially we are constantly repeating operations of the formso at every point the subgroup generated by
kandlcoincides with the subgroup generated bygandh.I do think this is somewhat slower, and I also got rid of some optimisation which I wasn't sure how to "port"... but it doesn't seem too bad?
(Note: this PR includes #124, #126, and the suggestions from #127 and #128 to make tests more reliable... Most of my recent bug reports were discovered when trying to test this algorithm.)