ci(python): cross-build x86_64-mac wheel on macos-latest instead of dropping it#13
Merged
Merged
Conversation
…ropping it Commit 6c41b5d unblocked the PyPI publish by removing the macos-13 / x86_64-apple-darwin wheel target, since the Intel-mac runner is retired and queued forever. But deleting the target forces every Intel-Mac user onto the sdist, which compiles Rust from source — a needless capability regression. The retired *runner* was the problem, not the *target*. release-binary.yml already cross-builds x86_64-apple-darwin on the macos-latest (Apple-silicon) runner for the same crate and native deps (bundled sqlite/zstd). Do the same here: restore the target with os: macos-latest. Net change vs. the original hanging config is a one-line runner swap (macos-13 -> macos-latest). Also corrected the matrix comment, which falsely cited docs/ROADMAP.md as tracking the omitted targets (it tracks none of them). - Restore x86_64-apple-darwin wheel, built on macos-latest - Fix misleading "Tracked in docs/ROADMAP.md" comment Found via /adversarial-review (Claude + Gemini agreed; Codex unavailable). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Commit 6c41b5d unblocked the PyPI publish by removing the
macos-13/x86_64-apple-darwinwheel target (the Intel-mac runner is retired and queued forever). But deleting the target forces every Intel-Mac user onto the sdist, which compiles Rust from source — a needless capability regression.The retired runner was the problem, not the target.
release-binary.ymlalready cross-buildsx86_64-apple-darwinon themacos-latest(Apple-silicon) runner for the same crate and native deps (bundled sqlite/zstd). This PR does the same inrelease-python.yml.Net change vs. the original hanging config: a one-line runner swap (
macos-13→macos-latest). Publish stays unblocked and Intel-Mac users get a real wheel again.Changes
x86_64-apple-darwinwheel, built onmacos-latestdocs/ROADMAP.mdas tracking omitted targets (it tracks none)Validation
wheels-<target>) remain unique → nodownload-artifactcollision inpublishpublish: needs [build, sdist]gating unchangedFound via
/adversarial-review— Claude + Gemini independently agreed cross-building beats dropping; Codex was unavailable (usage limit).🤖 Generated with Claude Code