Build summary implementation#2
Open
gabegrieve wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR expands on the
BuildHeadercomponent by introducing an expanded element designed to surface more information about the failing build.The new element has been designed to give the most visual weight to the failing steps and jobs, while keeping them in the context of the wider pipeline. It uses the mock data available in
src/data/mockBuildSteps.tsto surface specifics about the failing job.Figma explorations can be found here.
Notes
This PR includes three
TODOsthat have been added to reference during discussions about tradeoffs.