PR de Correção#1
Open
jvpalves wants to merge 23 commits into
Open
Conversation
jvpalves
commented
Apr 8, 2021
jvpalves
left a comment
jvpalves
left a comment
Author
There was a problem hiding this comment.
Oi, gente! O projeto de vocês foi consiiderado acima do esperado. Meus mais seinceros parabéns. O conteúdo do módulo 4 está perfeito! Deixei alguns comentários no corpo do projeto, mas em linhas gerais está tudo muito bom!
| # LABENU SYSTEM | ||
|
|
||
| ## 📚📰 Documentação no Postman | ||
| https://documenter.getpostman.com/view/14148928/TzCMe8Jy |
Comment on lines
+52
to
+58
| if ( | ||
| period.toLowerCase() !== "noturno" && | ||
| period.toLowerCase() !== "integral" | ||
| ) { | ||
| errorCode = 422; | ||
| throw new Error(`'period' options are: 'Noturno' or 'Integral'.`); | ||
| } |
Author
There was a problem hiding this comment.
Muito bom! Seria legal usar um ENUM aqui.
| } | ||
|
|
||
| // Insere as informações no Banco de Dados | ||
| await insertClass(id, modName, startDate, endDate, module); |
Author
There was a problem hiding this comment.
Vale a pena transformar estes parâmetros em um objeto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
observações sobre o projeto.