fix(otel): prevent PII redaction from corrupting session/user IDs and validate card numbers with Luhn check - #198
Open
sy0u1ti wants to merge 1 commit into
Open
Conversation
…identifiers from PII redaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195.
What does this PR do?
Fixes an issue where
TraceConfig(pii_redaction=True)corrupted session IDs, user IDs, timestamps, and UUIDs.Why?
<CREDIT_CARD>.<PHONE_NUMBER>.TraceConfig.mask()applied PII redaction unconditionally to all span attribute values, mutating core correlation identifiers (session.id,user.id,gen_ai.conversation.id).Changes
_luhn_check) so only valid credit card numbers are redacted.(?<!\d)and(?!\d)) to_PHONE_REto prevent matching parts of longer numbers or timestamps.SpanAttributes.SESSION_ID,SpanAttributes.USER_ID,SpanAttributes.GEN_AI_CONVERSATION_ID) from free-text PII masking inTraceConfig.mask().python/tests/test_pii_redaction.py.How was it tested?
pytest tests/test_pii_redaction.py tests/test_config.py -q(25 passed)<CREDIT_CARD>.1725700000000) remain intact.session.idanduser.idpass throughmask()unchanged.