Refactor: Restructure project into pages/ and common/ with co-location convention.#31
Merged
Merged
Conversation
1d40185 to
7b474fb
Compare
Collaborator
|
/lgtm |
matejvasek
approved these changes
May 29, 2026
Collaborator
|
From Claude: Minor test isolation regression in The old code had explicit // old — describe scope
beforeEach(() => {
onSubmit.mockClear();
onCancel.mockClear();
});The refactor replaced this with just No current test breaks (none assert on call counts), but it's a latent isolation issue. Fix: use |
011932f to
99446d5
Compare
Restructure src/ into pages/ and common/ directories. Page-specific components (CreateFunctionForm, FileTreeView, FunctionTable, EmptyState) move next to their page. Shared code (services, context, utils, UserAvatar) moves to common/. Extract EditToolbar (with LeaveModal) from FunctionEditPage into its own file with tests. Replace runtime import of @patternfly/react-code-editor with import type to avoid pulling Monaco workers into the bundle. Update ARCHITECTURE.md, TESTING.md, and WORKFLOW.md with co-location convention and related rules. Also add yarn ci script, rework init-session startup sequence, and clean up features.json. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
99446d5 to
b586950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes