Add refresh button to functions list page#26
Merged
Conversation
Collaborator
Author
|
There is potential bug if the user disconnects while a refresh is in flight. But I am not sure. As of now we cannot really disconnect. |
Collaborator
Author
|
twoGiants
requested changes
May 18, 2026
Collaborator
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
Will finish review tomorrow.
matejvasek
force-pushed
the
list-ux-imp-rebased
branch
from
22145e8 to
ac2a97c
Compare
twoGiants
previously requested changes
May 21, 2026
matejvasek
added a commit
that referenced
this pull request
May 21, 2026
Remove tooltip from refresh button. Drop useCallback from onRefresh. Extract loadFunctions as a standalone async function called directly from onRefresh and from useEffect for initial load, eliminating the refreshKey state. Signed-off-by: Matej Vašek <matejvasek@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
twoGiants
reviewed
May 21, 2026
matejvasek
force-pushed
the
list-ux-imp-rebased
branch
from
170d5bb to
e80fcbe
Compare
Add a manual refresh button to the functions list that re-fetches repos from GitHub on click. The button uses the PF Button isLoading prop for a native spinner and is disabled while a fetch is in flight. Place create and refresh buttons in a PF Toolbar above the table, separated by a vertical divider. Fix a caching bug in GithubService where deleted repos persisted after refresh. Replace the stale merge logic with a pendingRepos buffer that only keeps locally created repos until GitHub's search index catches up. Signed-off-by: Matej Vašek <matejvasek@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
matejvasek
force-pushed
the
list-ux-imp-rebased
branch
from
e80fcbe to
af32117
Compare
gauron99
approved these changes
May 29, 2026
gauron99
dismissed
twoGiants’s stale review
gauron99 reviewed. Enjoy PTO Stas! I hope I dont break anything major!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pendingReposbuffer that only keeps locally-created repos until GitHub's search index catches up.Test plan
listFunctionReposagain