Closed
Conversation
creydr
force-pushed
the
use-builder-from-func-config
branch
from
447b7ec to
b5d3baa
Compare
Collaborator
Author
|
Requires func CLI fixes from https://github.com/knative/func/pull/3575/files |
Collaborator
Author
|
Will be superseeded by #36 |
auto-merge was automatically disabled
April 8, 2026 09:31
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator was hardcoding Builder to 's2i' for all deployments, regardless of what builder the function was originally deployed with.
This PR addresses it and removes passing s2i as builder and let func decide on its own (based on the repo config).