Add missing fileNameWithLine#310
Open
SebastienGllmt wants to merge 1 commit into
Open
Conversation
terehov
added a commit
that referenced
this pull request
Jun 27, 2026
Add fileNameWithLine to IPrettyLogStyles so it can be styled like the other placeholders, and make ISettings.prettyLogStyles reference IPrettyLogStyles instead of duplicating the inline shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fileNameWithLineis meant to be part of the settings as per the docs, but it was accidentally omitted in the type definition.To avoid this kind of error, I also changed it so that the
prettyLogStylesis not duplicated in two places to make sure they're always in sync