Repository navigation
Give the starters a distinct Fullbleed print favicon - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The starter tab icon's lowercase f silhouette resembles Facebook's mark. Replace it in the browser, React and Vue starters with a cream/orange page framed by crop marks, keeping Fullbleed's existing forest-green palette. Version the icon URL so returning tabs request the replacement.
Validation: rendered and visually inspected the SVG at 16, 20, 24, 32, 64 and 128 pixels against light and dark tab backgrounds. All three source icons are byte-identical. Only the three SVGs and their HTML icon URLs change; package dependencies and document templates are unchanged. The matching downloadable projects and hosted demos are being updated in fullbleed-engine/docs#148.