Repository navigation
Preserve searchable invoice references in the React starter - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component invoice inherited letter spacing and uppercase styling from its decorative label. PDFium could not find
NS-1042, and a mixed-case reference would lose its original case. Render the reference in its own text component with normal spacing and no case transformation.The browser regression checks now require exact pypdf extraction and case-sensitive PDFium search for both the default reference and
Ref-aBc-2042. They deliberately keep whitespace intact.Validation: the negative control reproduces the failure in the current public demo. The corrected project passes its type check, production build, repeat rendering of six component fixtures, and 128 real Chrome checks. Browser PDFs and previews match the installed Node renderer; the existing HTML invoice and report PDF bytes are unchanged. The two affected single-page previews were visually reviewed. Retained evidence is in
verification/react-invoice-references.json.The starter keeps public
fullbleed@0.6.0, engine2.5.24, and every existing dependency pin. No package release is required.