Repository navigation
Build and preview PDFs from typed components in React - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The React starter currently sends users to HTML/CSS templates even though Fullbleed now supports typed document components. Make a component-authored invoice the first screen, with editable rows, integer-cents amounts, credits, paid state and color. Keep the existing HTML invoice/report designs available, including direct links.
The preview hook accepts either a composed document or HTML input, and accepts null while data is invalid so stale output clears without starting a worker. Dedicated print TSX files use Fullbleed's JSX pragma. Excluding those modules from React Fast Refresh fixes a reproduced stale-preview problem when their imported stylesheet changes; the real Vite test edits TSX and styles and verifies both resulting PDFs while preserving the form values.
Validation: the project pins public fullbleed 0.6.0 with unchanged engine 2.5.24 and other dependencies. Production and development StrictMode each pass 124 browser checks locally. Six component fixtures reproduce installed Node PDFs and every PNG, including a three-page, 20-row case; the old invoice/report bytes are unchanged. The real development server passes 9 checks. Source CI repeats browser coverage in Chrome, Firefox and WebKit. Local evidence is in verification/react-components060.json; this changes the starter and documentation, without a package or engine release.
All 16 candidate CI jobs passed. The merged tree is identical to the tested source.