Repository navigation
Bring engine 2.5.22 layout fixes to Node and browser - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node and browser applications currently bundle engine 2.5.11, so they miss recent fixes to nested counters, filtered overflow, border-image tiling, and floated initials. Package 0.4.1 pins the unmodified published 2.5.22 crate and enables its native
svg_rasterfallback. The public JavaScript API and memory limit remain unchanged.Thirteen fixtures retain the engine release's independent text, color, and Chrome print expectations. Tests cover worker/process rendering, native/WASM equality, and actual browser downloads. The public 0.4.0 control fails 24 of 26 worker/process cases across all four families; the corrected candidate passes all 26. A pin-only candidate revealed four blank SVG cases, which is why the build now requires and records the resolved SVG feature.
The invoice/report baseline retains exactly the reviewed PDF bytes, previews, PDFium pixels, text, inputs, and fonts. Test-only Noto Sans and its license are excluded from the npm tarball. CI and the release gate require Windows/Linux independent results and all three browser results.
Local validation: 47 JavaScript tests, 20 Python verifier tests, TypeScript, Rust formatting, 45 native/WASM fixtures, isolated packed installation and recovery, font subsets/families, inline and Standard 14 checks, 144 Chrome checks plus 13 independently inspected browser PDFs. All four designed invoice/report pages and representative fixes were visually reviewed. Full CI is required before publication; no broad CSS or PDF standards conformance claim, and issue #7 remains separate.