Repository navigation
Fix blank standard-font previews in JavaScript starters - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting HTML/CSS that uses unembedded Helvetica, Times, or Courier into the public browser, React, or Vue starter can create a valid PDF with a blank preview. Pin all four JavaScript starters, including Next.js, to the already-published Fullbleed 0.3.2 / engine 2.5.11 fix. Other dependency versions and application source stay unchanged.
Add a shared browser check that independently confirms unembedded Helvetica PDF faces and visible pixels in the edited-template preview. The check rejects the old live 0.3.1 starter. All three old live editors also reproduced blank previews for 12 standard faces with intact PDF text.
Validation: local Chrome starter checks pass (browser 25, React 37, Vue 42); 11 unchanged browser/React fixture PDFs retain reviewed 0.3.1 hashes; Next.js passes all 17 isolated standalone checks and retains its preview bytes. Detailed local evidence is in
verification/starters-032.json. Existing three-browser, React StrictMode, and Next.js platform workflows provide the CI gate. No SDK release or engine source change.