[Repo Assist] feat: add filter, iter, fold, exists, forall, choose, tryFind, toList, toArray, ofList, ofArray, keys, values to PersistentHashM [Content truncated due to length]#254
Open
github-actions[bot] wants to merge 2 commits intomasterfrom
Conversation
…, toArray, ofList, ofArray, keys, values to PersistentHashMap; 16 new tests All 754 tests pass. Addresses #152 (Align Collection Module functions with FSharp.Collections). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
PersistentHashMapwas missing many common collection functions that exist inFSharp.Collections.Map. This PR adds 13 new functions to align the API and addresses #152.tryFindSome valuefor an existing key,Nonefor missingfiltertrueiterfoldexiststrueif any entry satisfies the predicateforalltrueif all entries satisfy the predicatechooseNoneresultstoList(key * value) listtoArray(key * value) arrayofList(key * value) listofArray(key * value) arraykeysvaluesMotivation
FSharp.Collections.Maphas all of these functions. Consumers who switch fromMaptoPersistentHashMapfor its O(log32n) operations hit immediate API gaps. Closing this gap makesPersistentHashMapa first-class persistent map.Test Status
✅ All 754 tests pass (760 total, 6 pre-existing ptests skipped). 16 new tests added covering all new functions, including round-trip and edge-case checks.
Closes (partially) #152